tests(pro): bump pycloudlib add noble release to pro tests #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
force-pushed
the
tests-pro-gcp
branch
from
1888268
to
bfd0878
Compare
TheRealFalcon
approved these changes
Sep 19, 2024
| @@ -236,7 +237,7 @@ def maybe_install_cloud_init(session_cloud: IntegrationCloud): | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif( | |||
| not all([IS_UBUNTU, CURRENT_RELEASE in [BIONIC, FOCAL, JAMMY]]), | |||
| not all(CURRENT_RELEASE in [BIONIC, FOCAL, JAMMY, NOBLE]), | |||
There was a problem hiding this comment.
Nit: all not needed anymore.
blackboxsw
force-pushed
the
tests-pro-gcp
branch
from
bfd0878
to
b0f00b9
Compare
Since Noble is an LTS which supports Ubuntu Pro add integration test coverage for that feature. Bump pycloudlib dependency to 1!9.2 which allows cloud-init integration tests to obtain service_account_email configuration from the .config/pycloudlib.toml: [gce] credentials_path = <path> without the need to also provide `service_account_email` in pycloudlib.toml.
blackboxsw
force-pushed
the
tests-pro-gcp
branch
from
b0f00b9
to
cf64c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Fixes jenkins failures about service account https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-gce/lastSuccessfulBuild/testReport/junit/tests.integration_tests.modules.test_ubuntu_pro/TestUbuntuAdvantagePro/test_custom_services/
Test Steps
Merge type